liria/dora-zed
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 3 Wiki Activity

Upgrade to dora 1.0 and a shell-free build #10

New Issue
Closed
opened 2026-09-04 20:35:01 +00:00 by cristhian · 0 comments
cristhian commented 2026-09-04 20:35:01 +00:00
Owner
Copy Link
Copy Source

Feature: Upgrade to dora 1.0 and a shell-free build

User Story

As a dataflow author,
I want dora-zed to build and run under dora 1.0,
so that it can be referenced from a 1.0 dataflow.

Requirements

  • Build against the dora 1.0 C++ node API; verify with dora-cli 1.0.1.
  • DoraTargets.cmake: link the release build. dora_link_dirs currently points at target/debug in both branches.
  • Replace the build command with scripts/build.sh, invoked as build: scripts/build.sh.
  • Replace git_checkout: with tag: in README.md and dataflow.yml.
  • Update the dependency table in README.md to state the dora version.

Acceptance Criteria

  • dora build dataflow.yml completes using scripts/build.sh.
  • dora run dataflow.yml starts the node and it publishes on tick.
  • git grep git_checkout returns no matches.
  • The binary links the release dora bindings.

Notes

dora 1.0 executes build commands directly rather than through a shell. The current
command mkdir -p build && cd build && cmake .. && make install relies on cd and &&
and will not work; verified separately that command substitution is also not expanded.

dora 1.0 dataflow YAML replaces git_checkout: with tag:, rev: or branch:, which
are mutually exclusive.

# Feature: Upgrade to dora 1.0 and a shell-free build ## User Story As a dataflow author, I want dora-zed to build and run under dora 1.0, so that it can be referenced from a 1.0 dataflow. ## Requirements - Build against the dora 1.0 C++ node API; verify with `dora-cli 1.0.1`. - `DoraTargets.cmake`: link the release build. `dora_link_dirs` currently points at `target/debug` in both branches. - Replace the build command with `scripts/build.sh`, invoked as `build: scripts/build.sh`. - Replace `git_checkout:` with `tag:` in `README.md` and `dataflow.yml`. - Update the dependency table in `README.md` to state the dora version. ## Acceptance Criteria - [ ] `dora build dataflow.yml` completes using `scripts/build.sh`. - [ ] `dora run dataflow.yml` starts the node and it publishes on `tick`. - [ ] `git grep git_checkout` returns no matches. - [ ] The binary links the release dora bindings. ## Notes dora 1.0 executes build commands directly rather than through a shell. The current command `mkdir -p build && cd build && cmake .. && make install` relies on `cd` and `&&` and will not work; verified separately that command substitution is also not expanded. dora 1.0 dataflow YAML replaces `git_checkout:` with `tag:`, `rev:` or `branch:`, which are mutually exclusive.
cristhian added this to the v0.2.0 Pure camera source on dora 1.0 milestone 2026-09-04 20:35:01 +00:00
cristhian added the priority:highchore labels 2026-09-04 20:35:01 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
blocked
Cannot proceed — external dependency
 bug
Something is broken or behaves incorrectly
 chore
Maintenance, dependencies, config, cleanup
 docs
Documentation only, no code change
 feature
New functionality to be added
 needs-triage
Newly opened, not yet reviewed
 priority:high
Must be resolved in the current milestone
 priority:low
Nice to have, no urgency
No labels chore priority:high
Milestone
No items
No Milestone v0.2.0 Pure camera source on dora 1.0
Projects
Clear projects
No projects
Assignees
Clear assignees
bot cristhian esteban vincent
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: liria/dora-zed#10