verify the webcam example, pin v0.1.1, and scope pytest #5

Merged
cristhian merged 2 commits from webcam-example-verified into main 2026-09-15 09:52:07 +00:00
Owner

Summary

dataflow_webcam.yml shipped with a caveat saying it validated but could not be run, because a git: node could not be fetched. The liria organization is public now, so it can — and running it turned up a second problem.

Changes

  • The example is verified. dora clones dora-webcam at the pinned tag, builds both nodes, and runs them against a real camera to a clean exit. The caveat is replaced with that fact.
  • The pin moves to v0.1.1. v0.1.0's own documentation shows an ssh:// URL, which dora cannot authenticate, so anyone copying the wiring out of that tag would have hit exactly the failure this example exists to show the absence of. The code in the two tags is identical.
  • pytest is scoped to tests/. dora run vendors a git: node's source into git/ inside the checkout, and pytest collected that node's tests too: running the example and then the suite reported 67 tests, 26 of them another project's. A failure there would have turned this repository red for a reason nobody would find quickly.

What a git: node does require is still documented, because it is not obvious: anonymous read access, which on Gitea means a public organization and not merely a public repository. A repository inside a private organization is internal and answers an anonymous clone with 401 even when the repository itself is marked public.

Validation

  • CI=true CAPTURE_FRAMES=20 dora run dataflow_webcam.yml --uv — both nodes finish successfully, clone included
  • dora validate clean on the gate dataflow and the manifest
  • 41 tests (not 67), ruff clean, pymarkdown clean
# Summary `dataflow_webcam.yml` shipped with a caveat saying it validated but could not be run, because a `git:` node could not be fetched. The `liria` organization is public now, so it can — and running it turned up a second problem. ## Changes - **The example is verified.** dora clones dora-webcam at the pinned tag, builds both nodes, and runs them against a real camera to a clean exit. The caveat is replaced with that fact. - **The pin moves to `v0.1.1`.** `v0.1.0`'s own documentation shows an `ssh://` URL, which dora cannot authenticate, so anyone copying the wiring out of that tag would have hit exactly the failure this example exists to show the absence of. The code in the two tags is identical. - **pytest is scoped to `tests/`.** `dora run` vendors a `git:` node's source into `git/` inside the checkout, and pytest collected that node's tests too: running the example and then the suite reported **67 tests, 26 of them another project's**. A failure there would have turned this repository red for a reason nobody would find quickly. What a `git:` node does require is still documented, because it is not obvious: **anonymous** read access, which on Gitea means a public *organization* and not merely a public repository. A repository inside a private organization is internal and answers an anonymous clone with `401` even when the repository itself is marked public. ## Validation - [x] `CI=true CAPTURE_FRAMES=20 dora run dataflow_webcam.yml --uv` — both nodes finish successfully, clone included - [x] `dora validate` clean on the gate dataflow and the manifest - [x] 41 tests (not 67), `ruff` clean, `pymarkdown` clean
cristhian added 2 commits 2026-09-15 09:51:12 +00:00
The example carried a caveat saying it validated but could not be run, because
a `git:` node could not be fetched. The organization is public now, so it can:
dora clones dora-webcam at the pinned tag, builds both nodes, and runs them
against a real camera to a clean exit.

The pin moves to v0.1.1, whose documentation shows the https URL. v0.1.0 points
at an ssh:// URL that dora cannot authenticate, so anyone copying the wiring out
of that tag would have hit the failure this example exists to demonstrate the
absence of.

What a `git:` node does require is still recorded, since it is not obvious:
anonymous read, which on Gitea means a public organization and not merely a
public repository.
scope pytest to this repository's tests
validate / validate (pull_request) Successful in 59m14s
7eeb83bf6d
`dora run` vendors a `git:` node's source into git/ inside the checkout, and
pytest collected that node's tests along with these: running the webcam example
and then the test suite reported 67 tests, 26 of them another project's. A
failure there would have gone red here, for a reason no one would find quickly.
cristhian merged commit a371bb07ba into main 2026-09-15 09:52:07 +00:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: liria/dora-image-view#5